X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/f0d519637c997df11d5b1a1b32b3d9e4a2872325..c2924c3bde785dc609eaff088e96a464426666e6:/src/common/webdav.test.ts?ds=sidebyside diff --git a/src/common/webdav.test.ts b/src/common/webdav.test.ts index d96465ba..2ab106fc 100644 --- a/src/common/webdav.test.ts +++ b/src/common/webdav.test.ts @@ -2,6 +2,7 @@ // // SPDX-License-Identifier: AGPL-3.0 +import { customEncodeURI } from "./url"; import { WebDAV } from "./webdav"; describe('WebDAV', () => { @@ -41,61 +42,85 @@ describe('WebDAV', () => { it('PUT', async () => { const { open, send, load, progress, createRequest } = mockCreateRequest(); - const onProgress = jest.fn(); const webdav = new WebDAV(undefined, createRequest); - const promise = webdav.put('foo', 'Test data', { onProgress }); + const promise = webdav.put('foo', 'Test data'); progress(); load(); const request = await promise; expect(open).toHaveBeenCalledWith('PUT', 'foo'); expect(send).toHaveBeenCalledWith('Test data'); - expect(onProgress).toHaveBeenCalled(); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('COPY', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); + webdav.defaults.baseURL = 'http://base'; const promise = webdav.copy('foo', 'foo-copy'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('COPY', 'foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'foo-copy'); + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); expect(request).toBeInstanceOf(XMLHttpRequest); }); - it('COPY - adds baseURL to Destination header', async () => { + it('COPY - adds baseURL with trailing slash to Destination header', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); - webdav.defaults.baseURL = 'base/'; + webdav.defaults.baseURL = 'http://base'; const promise = webdav.copy('foo', 'foo-copy'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('COPY', 'base/foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'base/foo-copy'); + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); + expect(request).toBeInstanceOf(XMLHttpRequest); + }); + + it('COPY - adds baseURL without trailing slash to Destination header', async () => { + const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); + const webdav = new WebDAV(undefined, createRequest); + webdav.defaults.baseURL = 'http://base'; + const promise = webdav.copy('foo', 'foo-copy'); + load(); + const request = await promise; + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('MOVE', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); - const promise = webdav.move('foo', 'foo-copy'); + webdav.defaults.baseURL = 'http://base'; + const promise = webdav.move('foo', 'foo-moved'); + load(); + const request = await promise; + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); + expect(request).toBeInstanceOf(XMLHttpRequest); + }); + + it('MOVE - adds baseURL with trailing slash to Destination header', async () => { + const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); + const webdav = new WebDAV(undefined, createRequest); + webdav.defaults.baseURL = 'http://base'; + const promise = webdav.move('foo', 'foo-moved'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('MOVE', 'foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'foo-copy'); + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); expect(request).toBeInstanceOf(XMLHttpRequest); }); - it('MOVE - adds baseURL to Destination header', async () => { + it('MOVE - adds baseURL without trailing slash to Destination header', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); - webdav.defaults.baseURL = 'base/'; + webdav.defaults.baseURL = 'http://base'; const promise = webdav.move('foo', 'foo-moved'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('MOVE', 'base/foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'base/foo-moved'); + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); expect(request).toBeInstanceOf(XMLHttpRequest); });