X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/ecd0b3c069eed7d411e3cec7d707b43ab6675081..bde7ca868a0c201544476da6c049a98c1188dde9:/src/common/config.ts diff --git a/src/common/config.ts b/src/common/config.ts index 0f935602..146ca90a 100644 --- a/src/common/config.ts +++ b/src/common/config.ts @@ -89,6 +89,7 @@ export interface ClusterConfigJSON { export class Config { baseUrl: string; keepWebServiceUrl: string; + keepWebInlineServiceUrl: string; remoteHosts: { [key: string]: string }; @@ -104,7 +105,8 @@ export class Config { apiRevision: number; } -export const buildConfig = (clusterConfigJSON: ClusterConfigJSON): Config => { +export const buildConfig = (clusterConfig: ClusterConfigJSON): Config => { + const clusterConfigJSON = removeTrailingSlashes(clusterConfig); const config = new Config(); config.rootUrl = clusterConfigJSON.Services.Controller.ExternalURL; config.baseUrl = `${config.rootUrl}/${ARVADOS_API_PATH}`; @@ -113,6 +115,7 @@ export const buildConfig = (clusterConfigJSON: ClusterConfigJSON): Config => { config.workbench2Url = clusterConfigJSON.Services.Workbench2.ExternalURL; config.workbenchUrl = clusterConfigJSON.Services.Workbench1.ExternalURL; config.keepWebServiceUrl = clusterConfigJSON.Services.WebDAVDownload.ExternalURL; + config.keepWebInlineServiceUrl = clusterConfigJSON.Services.WebDAV.ExternalURL; config.loginCluster = clusterConfigJSON.Login.LoginCluster; config.clusterConfig = clusterConfigJSON; config.apiRevision = 0; @@ -138,7 +141,7 @@ const removeTrailingSlashes = (config: ClusterConfigJSON): ClusterConfigJSON => svcs[s].ExternalURL = svcs[s].ExternalURL.replace(/\/+$/, ''); } }); - return {...config, Services: svcs}; + return { ...config, Services: svcs }; }; export const fetchConfig = () => { @@ -154,9 +157,8 @@ export const fetchConfig = () => { throw new Error(`Unable to start Workbench. API_HOST is undefined in ${WORKBENCH_CONFIG_URL} or the environment.`); } return Axios.get(getClusterConfigURL(workbenchConfig.API_HOST)).then(async response => { - const clusterConfigJSON = removeTrailingSlashes(response.data); - const apiRevision = await getApiRevision(clusterConfigJSON.Services.Controller.ExternalURL); - const config = { ...buildConfig(clusterConfigJSON), apiRevision }; + const apiRevision = await getApiRevision(response.data.Services.Controller.ExternalURL.replace(/\/+$/, '')); + const config = { ...buildConfig(response.data), apiRevision }; const warnLocalConfig = (varName: string) => console.warn( `A value for ${varName} was found in ${WORKBENCH_CONFIG_URL}. To use the Arvados centralized configuration instead, \ remove the entire ${varName} entry from ${WORKBENCH_CONFIG_URL}`); @@ -170,7 +172,7 @@ remove the entire ${varName} entry from ${WORKBENCH_CONFIG_URL}`); fileViewerConfigUrl = workbenchConfig.FILE_VIEWERS_CONFIG_URL; } else { - fileViewerConfigUrl = clusterConfigJSON.Workbench.FileViewersConfigURL || "/file-viewers-example.json"; + fileViewerConfigUrl = config.clusterConfig.Workbench.FileViewersConfigURL || "/file-viewers-example.json"; } config.fileViewersConfigUrl = fileViewerConfigUrl; @@ -180,7 +182,7 @@ remove the entire ${varName} entry from ${WORKBENCH_CONFIG_URL}`); vocabularyUrl = workbenchConfig.VOCABULARY_URL; } else { - vocabularyUrl = clusterConfigJSON.Workbench.VocabularyURL || "/vocabulary-example.json"; + vocabularyUrl = config.clusterConfig.Workbench.VocabularyURL || "/vocabulary-example.json"; } config.vocabularyUrl = vocabularyUrl; @@ -249,6 +251,7 @@ export const mockClusterConfigJSON = (config: Partial): Clust export const mockConfig = (config: Partial): Config => ({ baseUrl: "", keepWebServiceUrl: "", + keepWebInlineServiceUrl: "", remoteHosts: {}, rootUrl: "", uuidPrefix: "",