X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/b6ac7fe88d347582d39fffa002e300af222c578f..95bba613751af0c9371e15dc8d2d1612079a6fe5:/src/views-components/resource-properties-form/property-value-field.tsx diff --git a/src/views-components/resource-properties-form/property-value-field.tsx b/src/views-components/resource-properties-form/property-value-field.tsx index a2b53b3c..b8e525bf 100644 --- a/src/views-components/resource-properties-form/property-value-field.tsx +++ b/src/views-components/resource-properties-form/property-value-field.tsx @@ -6,7 +6,7 @@ import React from 'react'; import { WrappedFieldProps, Field, formValues, FormName, WrappedFieldInputProps, WrappedFieldMetaProps, change } from 'redux-form'; import { compose } from 'redux'; import { Autocomplete } from 'components/autocomplete/autocomplete'; -import { Vocabulary, isStrictTag, getTagValues, getTagValueID } from 'models/vocabulary'; +import { Vocabulary, isStrictTag, getTagValues, getTagValueID, getTagValueLabel, PropFieldSuggestion, getPreferredTagValues } from 'models/vocabulary'; import { PROPERTY_KEY_FIELD_ID, PROPERTY_KEY_FIELD_NAME } from 'views-components/resource-properties-form/property-key-field'; import { handleSelect, @@ -56,17 +56,29 @@ export const PropertyValueField = connectVocabularyAndPropertyKey( const PropertyValueInput = ({ vocabulary, propertyKeyId, propertyKeyName, ...props }: WrappedFieldProps & PropertyValueFieldProps) => ( s.synonyms && s.synonyms.length > 0 + ? `${s.label} (${s.synonyms.join('; ')})` + : s.label + } onSelect={handleSelect(PROPERTY_VALUE_FIELD_ID, data.form, props.input, props.meta)} - onBlur={handleBlur(PROPERTY_VALUE_FIELD_ID, data.form, props.meta, props.input, getTagValueID(propertyKeyId, props.input.value, vocabulary))} + onBlur={() => { + // Case-insensitive search for the value in the vocabulary + const foundValueID = getTagValueID(propertyKeyId, props.input.value, vocabulary); + if (foundValueID !== '') { + props.input.value = getTagValueLabel(propertyKeyId, foundValueID, vocabulary); + } + handleBlur(PROPERTY_VALUE_FIELD_ID, data.form, props.meta, props.input, foundValueID)(); + }} onChange={(e: ChangeEvent) => { const newValue = e.currentTarget.value; const tagValueID = getTagValueID(propertyKeyId, newValue, vocabulary); handleChange(data.form, tagValueID, props.input, props.meta, newValue); }} - {...buildProps(props)} /> )} />; @@ -83,7 +95,9 @@ const matchTagValues = ({ vocabulary, propertyKeyId }: PropertyValueFieldProps) const getSuggestions = (value: string, tagName: string, vocabulary: Vocabulary) => { const re = new RegExp(escapeRegExp(value), "i"); - return getTagValues(tagName, vocabulary).filter(v => re.test(v.label) && v.label !== value); + return getPreferredTagValues(tagName, vocabulary, value).filter( + val => (val.label !== value && re.test(val.label)) || + (val.synonyms && val.synonyms.some(s => re.test(s)))); }; const handleChange = (