X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/9cbd6231837df8564953330fc63ce0fb9b9454cc..e16f2125588512201e3bd22ae9a19e10cb69d367:/src/common/webdav.test.ts diff --git a/src/common/webdav.test.ts b/src/common/webdav.test.ts index c85f30e7..1149c451 100644 --- a/src/common/webdav.test.ts +++ b/src/common/webdav.test.ts @@ -13,34 +13,36 @@ describe('WebDAV', () => { const request = await promise; expect(open).toHaveBeenCalledWith('PROPFIND', 'http://foo.com/foo'); expect(setRequestHeader).toHaveBeenCalledWith('Authorization', 'Basic'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('allows to modify defaults after instantiation', async () => { const { open, load, setRequestHeader, createRequest } = mockCreateRequest(); - const webdav = new WebDAV(undefined, createRequest); - webdav.defaults.baseURL = 'http://foo.com/'; - webdav.defaults.headers = { Authorization: 'Basic' }; + const webdav = new WebDAV({ baseURL: 'http://foo.com/' }, createRequest); + webdav.setAuthorization('Basic'); const promise = webdav.propfind('foo'); load(); const request = await promise; expect(open).toHaveBeenCalledWith('PROPFIND', 'http://foo.com/foo'); expect(setRequestHeader).toHaveBeenCalledWith('Authorization', 'Basic'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('PROPFIND', async () => { - const { open, load, createRequest } = mockCreateRequest(); + const { open, load, setRequestHeader, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); const promise = webdav.propfind('foo'); load(); const request = await promise; expect(open).toHaveBeenCalledWith('PROPFIND', 'foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('PUT', async () => { - const { open, send, load, progress, createRequest } = mockCreateRequest(); + const { open, send, load, progress, setRequestHeader, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); const promise = webdav.put('foo', 'Test data'); progress(); @@ -48,62 +50,90 @@ describe('WebDAV', () => { const request = await promise; expect(open).toHaveBeenCalledWith('PUT', 'foo'); expect(send).toHaveBeenCalledWith('Test data'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('COPY', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); - const webdav = new WebDAV(undefined, createRequest); + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); const promise = webdav.copy('foo', 'foo-copy'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('COPY', 'foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'foo-copy'); + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); - it('COPY - adds baseURL to Destination header', async () => { + it('COPY - adds baseURL with trailing slash to Destination header', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); - const webdav = new WebDAV(undefined, createRequest); - webdav.defaults.baseURL = 'base/'; + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); + const promise = webdav.copy('foo', 'foo-copy'); + load(); + const request = await promise; + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); + expect(request).toBeInstanceOf(XMLHttpRequest); + }); + + it('COPY - adds baseURL without trailing slash to Destination header', async () => { + const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); const promise = webdav.copy('foo', 'foo-copy'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('COPY', 'base/foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'base/foo-copy'); + expect(open).toHaveBeenCalledWith('COPY', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-copy'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('MOVE', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); - const webdav = new WebDAV(undefined, createRequest); - const promise = webdav.move('foo', 'foo-copy'); + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); + const promise = webdav.move('foo', 'foo-moved'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('MOVE', 'foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'foo-copy'); + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); - it('MOVE - adds baseURL to Destination header', async () => { + it('MOVE - adds baseURL with trailing slash to Destination header', async () => { const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); - const webdav = new WebDAV(undefined, createRequest); - webdav.defaults.baseURL = 'base/'; + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); const promise = webdav.move('foo', 'foo-moved'); load(); const request = await promise; - expect(open).toHaveBeenCalledWith('MOVE', 'base/foo'); - expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'base/foo-moved'); + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); + expect(request).toBeInstanceOf(XMLHttpRequest); + }); + + it('MOVE - adds baseURL without trailing slash to Destination header', async () => { + const { open, setRequestHeader, load, createRequest } = mockCreateRequest(); + const webdav = new WebDAV({ baseURL: 'http://base' }, createRequest); + const promise = webdav.move('foo', 'foo-moved'); + load(); + const request = await promise; + expect(open).toHaveBeenCalledWith('MOVE', 'http://base/foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Destination', 'http://base/foo-moved'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); it('DELETE', async () => { - const { open, load, createRequest } = mockCreateRequest(); + const { open, load, setRequestHeader, createRequest } = mockCreateRequest(); const webdav = new WebDAV(undefined, createRequest); const promise = webdav.delete('foo'); load(); const request = await promise; expect(open).toHaveBeenCalledWith('DELETE', 'foo'); + expect(setRequestHeader).toHaveBeenCalledWith('Cache-Control', 'no-cache'); expect(request).toBeInstanceOf(XMLHttpRequest); }); });