X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/795e98eac92b86652d3fe9de6657ffffc009d90e..074cc61145869165217e2d35a4b949f92a6829e7:/src/store/resource-type-filters/resource-type-filters.ts diff --git a/src/store/resource-type-filters/resource-type-filters.ts b/src/store/resource-type-filters/resource-type-filters.ts index ef1198bc..361b52a6 100644 --- a/src/store/resource-type-filters/resource-type-filters.ts +++ b/src/store/resource-type-filters/resource-type-filters.ts @@ -3,14 +3,15 @@ // SPDX-License-Identifier: AGPL-3.0 import { difference, pipe, values, includes, __ } from 'lodash/fp'; -import { createTree, setNode, TreeNodeStatus, TreeNode, Tree } from '~/models/tree'; -import { DataTableFilterItem, DataTableFilters } from '~/components/data-table-filters/data-table-filters-tree'; -import { ResourceKind } from '~/models/resource'; -import { FilterBuilder } from '~/services/api/filter-builder'; -import { getSelectedNodes } from '~/models/tree'; -import { CollectionType } from '~/models/collection'; -import { GroupContentsResourcePrefix } from '~/services/groups-service/groups-service'; -import { ContainerState } from '~/models/container'; +import { createTree, setNode, TreeNodeStatus, TreeNode, Tree } from 'models/tree'; +import { DataTableFilterItem, DataTableFilters } from 'components/data-table-filters/data-table-filters-tree'; +import { ResourceKind } from 'models/resource'; +import { FilterBuilder } from 'services/api/filter-builder'; +import { getSelectedNodes } from 'models/tree'; +import { CollectionType } from 'models/collection'; +import { GroupContentsResourcePrefix } from 'services/groups-service/groups-service'; +import { ContainerState } from 'models/container'; +import { ContainerRequestState } from 'models/container-request'; export enum ProcessStatusFilter { ALL = 'All', @@ -18,28 +19,35 @@ export enum ProcessStatusFilter { FAILED = 'Failed', COMPLETED = 'Completed', CANCELLED = 'Cancelled', - LOCKED = 'Locked', + ONHOLD = 'On hold', QUEUED = 'Queued' } export enum ObjectTypeFilter { PROJECT = 'Project', - PROCESS = 'Process', - COLLECTION = 'Data Collection', + WORKFLOW = 'Workflow', + COLLECTION = 'Data collection', + DEFINITION = 'Definition', +} + +export enum GroupTypeFilter { + PROJECT = 'Project (normal)', + FILTER_GROUP = 'Filter group', } export enum CollectionTypeFilter { GENERAL_COLLECTION = 'General', OUTPUT_COLLECTION = 'Output', LOG_COLLECTION = 'Log', + INTERMEDIATE_COLLECTION = 'Intermediate', } export enum ProcessTypeFilter { - MAIN_PROCESS = 'Main', - CHILD_PROCESS = 'Child', + MAIN_PROCESS = 'Runs', + CHILD_PROCESS = 'Intermediate Steps', } -const initFilter = (name: string, parent = '', isSelected?: boolean) => +const initFilter = (name: string, parent = '', isSelected?: boolean, isExpanded?: boolean) => setNode({ id: name, value: { name }, @@ -47,33 +55,42 @@ const initFilter = (name: string, parent = '', isSelected?: boolean) => children: [], active: false, selected: isSelected !== undefined ? isSelected : true, - expanded: false, + initialState: isSelected !== undefined ? isSelected : true, + expanded: isExpanded !== undefined ? isExpanded : false, status: TreeNodeStatus.LOADED, }); export const getSimpleObjectTypeFilters = pipe( (): DataTableFilters => createTree(), initFilter(ObjectTypeFilter.PROJECT), - initFilter(ObjectTypeFilter.PROCESS), + initFilter(ObjectTypeFilter.WORKFLOW), initFilter(ObjectTypeFilter.COLLECTION), + initFilter(ObjectTypeFilter.DEFINITION), ); // Using pipe() with more than 7 arguments makes the return type be 'any', // causing compile issues. export const getInitialResourceTypeFilters = pipe( (): DataTableFilters => createTree(), - initFilter(ObjectTypeFilter.PROJECT), pipe( - initFilter(ObjectTypeFilter.PROCESS), - initFilter(ProcessTypeFilter.MAIN_PROCESS, ObjectTypeFilter.PROCESS), - initFilter(ProcessTypeFilter.CHILD_PROCESS, ObjectTypeFilter.PROCESS) + initFilter(ObjectTypeFilter.PROJECT, '', true, true), + initFilter(GroupTypeFilter.PROJECT, ObjectTypeFilter.PROJECT), + initFilter(GroupTypeFilter.FILTER_GROUP, ObjectTypeFilter.PROJECT), + ), + pipe( + initFilter(ObjectTypeFilter.WORKFLOW, '', false, true), + initFilter(ObjectTypeFilter.DEFINITION, ObjectTypeFilter.WORKFLOW), + initFilter(ProcessTypeFilter.MAIN_PROCESS, ObjectTypeFilter.WORKFLOW), + initFilter(ProcessTypeFilter.CHILD_PROCESS, ObjectTypeFilter.WORKFLOW, false), ), pipe( - initFilter(ObjectTypeFilter.COLLECTION), + initFilter(ObjectTypeFilter.COLLECTION, '', true, true), initFilter(CollectionTypeFilter.GENERAL_COLLECTION, ObjectTypeFilter.COLLECTION), initFilter(CollectionTypeFilter.OUTPUT_COLLECTION, ObjectTypeFilter.COLLECTION), + initFilter(CollectionTypeFilter.INTERMEDIATE_COLLECTION, ObjectTypeFilter.COLLECTION), initFilter(CollectionTypeFilter.LOG_COLLECTION, ObjectTypeFilter.COLLECTION), ), + ); export const getInitialProcessTypeFilters = pipe( @@ -86,12 +103,12 @@ export const getInitialProcessStatusFilters = pipe( (): DataTableFilters => createTree(), pipe( initFilter(ProcessStatusFilter.ALL, '', true), + initFilter(ProcessStatusFilter.ONHOLD, '', false), + initFilter(ProcessStatusFilter.QUEUED, '', false), initFilter(ProcessStatusFilter.RUNNING, '', false), - initFilter(ProcessStatusFilter.FAILED, '', false), initFilter(ProcessStatusFilter.COMPLETED, '', false), initFilter(ProcessStatusFilter.CANCELLED, '', false), - initFilter(ProcessStatusFilter.QUEUED, '', false), - initFilter(ProcessStatusFilter.LOCKED, '', false), + initFilter(ProcessStatusFilter.FAILED, '', false), ), ); @@ -101,6 +118,7 @@ export const getTrashPanelTypeFilters = pipe( initFilter(ObjectTypeFilter.COLLECTION), initFilter(CollectionTypeFilter.GENERAL_COLLECTION, ObjectTypeFilter.COLLECTION), initFilter(CollectionTypeFilter.OUTPUT_COLLECTION, ObjectTypeFilter.COLLECTION), + initFilter(CollectionTypeFilter.INTERMEDIATE_COLLECTION, ObjectTypeFilter.COLLECTION), initFilter(CollectionTypeFilter.LOG_COLLECTION, ObjectTypeFilter.COLLECTION), ); @@ -116,23 +134,29 @@ const objectTypeToResourceKind = (type: ObjectTypeFilter) => { switch (type) { case ObjectTypeFilter.PROJECT: return ResourceKind.PROJECT; - case ObjectTypeFilter.PROCESS: + case ObjectTypeFilter.WORKFLOW: return ResourceKind.PROCESS; case ObjectTypeFilter.COLLECTION: return ResourceKind.COLLECTION; + case ObjectTypeFilter.DEFINITION: + return ResourceKind.WORKFLOW; } }; const serializeObjectTypeFilters = ({ fb, selectedFilters }: ReturnType) => { + const groupFilters = getMatchingFilters(values(GroupTypeFilter), selectedFilters); const collectionFilters = getMatchingFilters(values(CollectionTypeFilter), selectedFilters); const processFilters = getMatchingFilters(values(ProcessTypeFilter), selectedFilters); const typeFilters = pipe( () => new Set(getMatchingFilters(values(ObjectTypeFilter), selectedFilters)), + set => groupFilters.length > 0 + ? set.add(ObjectTypeFilter.PROJECT) + : set, set => collectionFilters.length > 0 ? set.add(ObjectTypeFilter.COLLECTION) : set, set => processFilters.length > 0 - ? set.add(ObjectTypeFilter.PROCESS) + ? set.add(ObjectTypeFilter.WORKFLOW) : set, set => Array.from(set) )(); @@ -140,7 +164,7 @@ const serializeObjectTypeFilters = ({ fb, selectedFilters }: ReturnType 0 ? fb.addIsA('uuid', typeFilters.map(objectTypeToResourceKind)) - : fb, + : fb.addIsA('uuid', ResourceKind.NONE), selectedFilters, }; }; @@ -153,6 +177,10 @@ const collectionTypeToPropertyValue = (type: CollectionTypeFilter) => { return CollectionType.OUTPUT; case CollectionTypeFilter.LOG_COLLECTION: return CollectionType.LOG; + case CollectionTypeFilter.INTERMEDIATE_COLLECTION: + return CollectionType.INTERMEDIATE; + default: + return CollectionType.GENERAL; } }; @@ -182,6 +210,30 @@ const buildCollectionTypeFilters = ({ fb, filters }: { fb: FilterBuilder, filter } }; +const serializeGroupTypeFilters = ({ fb, selectedFilters }: ReturnType) => pipe( + () => getMatchingFilters(values(GroupTypeFilter), selectedFilters), + filters => filters, + mappedFilters => ({ + fb: buildGroupTypeFilters({ fb, filters: mappedFilters, use_prefix: true }), + selectedFilters + }) +)(); + +const GROUP_TYPES = values(GroupTypeFilter); + +const buildGroupTypeFilters = ({ fb, filters, use_prefix }: { fb: FilterBuilder, filters: string[], use_prefix: boolean }) => { + switch (true) { + case filters.length === 0 || filters.length === GROUP_TYPES.length: + return fb; + case includes(GroupTypeFilter.PROJECT, filters): + return fb.addEqual('groups.group_class', 'project'); + case includes(GroupTypeFilter.FILTER_GROUP, filters): + return fb.addEqual('groups.group_class', 'filter'); + default: + return fb; + } +}; + const serializeProcessTypeFilters = ({ fb, selectedFilters }: ReturnType) => pipe( () => getMatchingFilters(values(ProcessTypeFilter), selectedFilters), filters => filters, @@ -210,6 +262,7 @@ const buildProcessTypeFilters = ({ fb, filters, use_prefix }: { fb: FilterBuilde export const serializeResourceTypeFilters = pipe( createFiltersBuilder, serializeObjectTypeFilters, + serializeGroupTypeFilters, serializeCollectionTypeFilters, serializeProcessTypeFilters, ({ fb }) => fb.getFilters(), @@ -234,30 +287,34 @@ export const serializeSimpleObjectTypeFilters = (filters: Tree { +export const buildProcessStatusFilters = (fb: FilterBuilder, activeStatusFilter: string, resourcePrefix?: string): FilterBuilder => { switch (activeStatusFilter) { + case ProcessStatusFilter.ONHOLD: { + fb.addDistinct('state', ContainerRequestState.FINAL, resourcePrefix); + fb.addEqual('priority', '0', resourcePrefix); + fb.addIn('container.state', [ContainerState.QUEUED, ContainerState.LOCKED], resourcePrefix); + break; + } case ProcessStatusFilter.COMPLETED: { - fb.addEqual('container.state', ContainerState.COMPLETE); - fb.addEqual('container.exit_code', '0'); + fb.addEqual('container.state', ContainerState.COMPLETE, resourcePrefix); + fb.addEqual('container.exit_code', '0', resourcePrefix); break; } case ProcessStatusFilter.FAILED: { - fb.addEqual('container.state', ContainerState.COMPLETE); - fb.addDistinct('container.exit_code', '0'); + fb.addEqual('container.state', ContainerState.COMPLETE, resourcePrefix); + fb.addDistinct('container.exit_code', '0', resourcePrefix); break; } case ProcessStatusFilter.QUEUED: { - fb.addEqual('container.state', ContainerState.QUEUED); - fb.addDistinct('container.priority', '0'); + fb.addEqual('container.state', ContainerState.QUEUED, resourcePrefix); + fb.addDistinct('priority', '0', resourcePrefix); break; } case ProcessStatusFilter.CANCELLED: - case ProcessStatusFilter.FAILED: - case ProcessStatusFilter.LOCKED: case ProcessStatusFilter.RUNNING: { - fb.addEqual('container.state', activeStatusFilter); + fb.addEqual('container.state', activeStatusFilter, resourcePrefix); break; } } return fb; -}; \ No newline at end of file +};