X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/6f8e509988756deb7e05a760e718d1ade164fd19..45ee419ff7952fc722a139666c327a321a92cc81:/src/services/common-service/common-resource-service.test.ts diff --git a/src/services/common-service/common-resource-service.test.ts b/src/services/common-service/common-resource-service.test.ts index 385485db..a6a8b9d0 100644 --- a/src/services/common-service/common-resource-service.test.ts +++ b/src/services/common-service/common-resource-service.test.ts @@ -6,13 +6,18 @@ import { CommonResourceService } from "./common-resource-service"; import axios, { AxiosInstance } from "axios"; import MockAdapter from "axios-mock-adapter"; import { Resource } from "src/models/resource"; -import { ProgressFn } from "~/services/api/api-progress"; +import { ApiActions } from "~/services/api/api-actions"; + +const actions: ApiActions = { + progressFn: (id: string, working: boolean) => {}, + errorFn: (id: string, message: string) => {} +}; export const mockResourceService = >( - Service: new (client: AxiosInstance, progressFn: ProgressFn) => C) => { + Service: new (client: AxiosInstance, actions: ApiActions) => C) => { const axiosInstance = axios.create(); const axiosMock = new MockAdapter(axiosInstance); - const service = new Service(axiosInstance, (id, working) => {}); + const service = new Service(axiosInstance, actions); Object.keys(service).map(key => service[key] = jest.fn()); return service; }; @@ -20,7 +25,6 @@ export const mockResourceService = { const axiosInstance = axios.create(); const axiosMock = new MockAdapter(axiosInstance); - const progressFn = (id: string, working: boolean) => {}; beforeEach(() => { axiosMock.reset(); @@ -31,14 +35,14 @@ describe("CommonResourceService", () => { .onPost("/resource/") .reply(200, { owner_uuid: "ownerUuidValue" }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", progressFn); + const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); const resource = await commonResourceService.create({ ownerUuid: "ownerUuidValue" }); expect(resource).toEqual({ ownerUuid: "ownerUuidValue" }); }); it("#create maps request params to snake case", async () => { axiosInstance.post = jest.fn(() => Promise.resolve({data: {}})); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", progressFn); + const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); await commonResourceService.create({ ownerUuid: "ownerUuidValue" }); expect(axiosInstance.post).toHaveBeenCalledWith("/resource/", {owner_uuid: "ownerUuidValue"}); }); @@ -48,7 +52,7 @@ describe("CommonResourceService", () => { .onDelete("/resource/uuid") .reply(200, { deleted_at: "now" }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", progressFn); + const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); const resource = await commonResourceService.delete("uuid"); expect(resource).toEqual({ deletedAt: "now" }); }); @@ -56,11 +60,22 @@ describe("CommonResourceService", () => { it("#get", async () => { axiosMock .onGet("/resource/uuid") - .reply(200, { modified_at: "now" }); + .reply(200, { + modified_at: "now", + properties: { + responsible_owner_uuid: "another_owner" + } + }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", progressFn); + const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); const resource = await commonResourceService.get("uuid"); - expect(resource).toEqual({ modifiedAt: "now" }); + // Only first level keys are mapped to camel case + expect(resource).toEqual({ + modifiedAt: "now", + properties: { + responsible_owner_uuid: "another_owner" + } + }); }); it("#list", async () => { @@ -71,19 +86,26 @@ describe("CommonResourceService", () => { offset: 2, limit: 10, items: [{ - modified_at: "now" + modified_at: "now", + properties: { + is_active: true + } }], items_available: 20 }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", progressFn); + const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); const resource = await commonResourceService.list({ limit: 10, offset: 1 }); + // First level keys are mapped to camel case inside "items" arrays expect(resource).toEqual({ kind: "kind", offset: 2, limit: 10, items: [{ - modifiedAt: "now" + modifiedAt: "now", + properties: { + is_active: true + } }], itemsAvailable: 20 });