X-Git-Url: https://git.arvados.org/arvados-workbench2.git/blobdiff_plain/229eaf53b39af3a7e9408ed5f7e49d74b318445a..f6396d366359d62ec22ca7a0efd4bf22a395f933:/src/store/groups-panel/groups-panel-actions.ts diff --git a/src/store/groups-panel/groups-panel-actions.ts b/src/store/groups-panel/groups-panel-actions.ts index 8632098e..6e63702e 100644 --- a/src/store/groups-panel/groups-panel-actions.ts +++ b/src/store/groups-panel/groups-panel-actions.ts @@ -3,25 +3,23 @@ // SPDX-License-Identifier: AGPL-3.0 import { Dispatch } from 'redux'; -import { reset, startSubmit, stopSubmit, FormErrors } from 'redux-form'; -import { bindDataExplorerActions } from "~/store/data-explorer/data-explorer-action"; -import { dialogActions } from '~/store/dialog/dialog-actions'; -import { Person } from '~/views-components/sharing-dialog/people-select'; -import { RootState } from '~/store/store'; -import { ServiceRepository } from '~/services/services'; -import { getResource } from '~/store/resources/resources'; -import { GroupResource } from '~/models/group'; -import { getCommonResourceServiceError, CommonResourceServiceError } from '~/services/common-service/common-resource-service'; -import { snackbarActions, SnackbarKind } from '~/store/snackbar/snackbar-actions'; -import { PermissionLevel, PermissionResource } from '~/models/permission'; -import { PermissionService } from '~/services/permission-service/permission-service'; -import { FilterBuilder } from '~/services/api/filter-builder'; +import { reset, startSubmit, stopSubmit, FormErrors, initialize } from 'redux-form'; +import { bindDataExplorerActions } from "store/data-explorer/data-explorer-action"; +import { dialogActions } from 'store/dialog/dialog-actions'; +import { RootState } from 'store/store'; +import { ServiceRepository } from 'services/services'; +import { getResource } from 'store/resources/resources'; +import { GroupResource, GroupClass } from 'models/group'; +import { getCommonResourceServiceError, CommonResourceServiceError } from 'services/common-service/common-resource-service'; +import { snackbarActions, SnackbarKind } from 'store/snackbar/snackbar-actions'; +import { PermissionLevel } from 'models/permission'; +import { PermissionService } from 'services/permission-service/permission-service'; +import { FilterBuilder } from 'services/api/filter-builder'; +import { ProjectUpdateFormDialogData, PROJECT_UPDATE_FORM_NAME } from 'store/projects/project-update-actions'; +import { PROJECT_CREATE_FORM_NAME } from 'store/projects/project-create-actions'; export const GROUPS_PANEL_ID = "groupsPanel"; -export const CREATE_GROUP_DIALOG = "createGroupDialog"; -export const CREATE_GROUP_FORM = "createGroupForm"; -export const CREATE_GROUP_NAME_FIELD_NAME = 'name'; -export const CREATE_GROUP_USERS_FIELD_NAME = 'users'; + export const GROUP_ATTRIBUTES_DIALOG = 'groupAttributesDialog'; export const GROUP_REMOVE_DIALOG = 'groupRemoveDialog'; @@ -30,9 +28,14 @@ export const GroupsPanelActions = bindDataExplorerActions(GROUPS_PANEL_ID); export const loadGroupsPanel = () => GroupsPanelActions.REQUEST_ITEMS(); export const openCreateGroupDialog = () => - (dispatch: Dispatch) => { - dispatch(dialogActions.OPEN_DIALOG({ id: CREATE_GROUP_DIALOG, data: {} })); - dispatch(reset(CREATE_GROUP_FORM)); + (dispatch: Dispatch, getState: () => RootState) => { + dispatch(initialize(PROJECT_CREATE_FORM_NAME, {})); + dispatch(dialogActions.OPEN_DIALOG({ + id: PROJECT_CREATE_FORM_NAME, + data: { + sourcePanel: GroupClass.ROLE, + } + })); }; export const openGroupAttributes = (uuid: string) => @@ -44,7 +47,7 @@ export const openGroupAttributes = (uuid: string) => export const removeGroup = (uuid: string) => async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => { - dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Removing ...' })); + dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Removing ...', kind: SnackbarKind.INFO })); await services.groupsService.delete(uuid); dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Removed.', hideDuration: 2000, kind: SnackbarKind.SUCCESS })); dispatch(loadGroupsPanel()); @@ -63,50 +66,65 @@ export const openRemoveGroupDialog = (uuid: string) => })); }; -export interface CreateGroupFormData { - [CREATE_GROUP_NAME_FIELD_NAME]: string; - [CREATE_GROUP_USERS_FIELD_NAME]?: Person[]; -} - -export const createGroup = ({ name, users = [] }: CreateGroupFormData) => - async (dispatch: Dispatch, _: {}, { groupsService, permissionService }: ServiceRepository) => { - - dispatch(startSubmit(CREATE_GROUP_FORM)); +// Group edit dialog uses project update dialog with sourcePanel set to reload the appropriate parts +export const openGroupUpdateDialog = (resource: ProjectUpdateFormDialogData) => + (dispatch: Dispatch, getState: () => RootState) => { + dispatch(initialize(PROJECT_UPDATE_FORM_NAME, resource)); + dispatch(dialogActions.OPEN_DIALOG({ + id: PROJECT_UPDATE_FORM_NAME, + data: { + sourcePanel: GroupClass.ROLE, + } + })); + }; +export const updateGroup = (project: ProjectUpdateFormDialogData) => + async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => { + const uuid = project.uuid || ''; + dispatch(startSubmit(PROJECT_UPDATE_FORM_NAME)); try { + const updatedGroup = await services.groupsService.update(uuid, { name: project.name, description: project.description }); + dispatch(GroupsPanelActions.REQUEST_ITEMS()); + dispatch(reset(PROJECT_UPDATE_FORM_NAME)); + dispatch(dialogActions.CLOSE_DIALOG({ id: PROJECT_UPDATE_FORM_NAME })); + return updatedGroup; + } catch (e) { + dispatch(stopSubmit(PROJECT_UPDATE_FORM_NAME)); + const error = getCommonResourceServiceError(e); + if (error === CommonResourceServiceError.UNIQUE_NAME_VIOLATION) { + dispatch(stopSubmit(PROJECT_UPDATE_FORM_NAME, { name: 'Group with the same name already exists.' } as FormErrors)); + } + return ; + } + }; - const newGroup = await groupsService.create({ name }); - +export const createGroup = ({ name, users = [], description }: ProjectUpdateFormDialogData) => + async (dispatch: Dispatch, _: {}, { groupsService, permissionService }: ServiceRepository) => { + dispatch(startSubmit(PROJECT_CREATE_FORM_NAME)); + try { + const newGroup = await groupsService.create({ name, description, groupClass: GroupClass.ROLE }); for (const user of users) { - await addGroupMember({ user, group: newGroup, dispatch, permissionService, }); - } - - dispatch(dialogActions.CLOSE_DIALOG({ id: CREATE_GROUP_DIALOG })); - dispatch(reset(CREATE_GROUP_FORM)); + dispatch(dialogActions.CLOSE_DIALOG({ id: PROJECT_CREATE_FORM_NAME })); + dispatch(reset(PROJECT_CREATE_FORM_NAME)); dispatch(loadGroupsPanel()); dispatch(snackbarActions.OPEN_SNACKBAR({ message: `${newGroup.name} group has been created`, kind: SnackbarKind.SUCCESS })); - return newGroup; - } catch (e) { - const error = getCommonResourceServiceError(e); - if (error === CommonResourceServiceError.UNIQUE_VIOLATION) { - dispatch(stopSubmit(CREATE_GROUP_FORM, { name: 'Group with the same name already exists.' } as FormErrors)); + if (error === CommonResourceServiceError.UNIQUE_NAME_VIOLATION) { + dispatch(stopSubmit(PROJECT_CREATE_FORM_NAME, { name: 'Group with the same name already exists.' } as FormErrors)); } - return; - } }; @@ -118,20 +136,18 @@ interface AddGroupMemberArgs { } /** - * Group membership is determined by whether the group has can_read permission on an object. + * Group membership is determined by whether the group has can_read permission on an object. * If a group G can_read an object A, then we say A is a member of G. - * + * * [Permission model docs](https://doc.arvados.org/api/permission-model.html) */ export const addGroupMember = async ({ user, group, ...args }: AddGroupMemberArgs) => { - await createPermission({ - head: { ...user }, - tail: { ...group }, + head: { ...group }, + tail: { ...user }, permissionLevel: PermissionLevel.CAN_READ, ...args, }); - }; interface CreatePermissionLinkArgs { @@ -143,83 +159,56 @@ interface CreatePermissionLinkArgs { } const createPermission = async ({ head, tail, permissionLevel, dispatch, permissionService }: CreatePermissionLinkArgs) => { - try { - await permissionService.create({ tailUuid: tail.uuid, headUuid: head.uuid, name: permissionLevel, }); - } catch (e) { - dispatch(snackbarActions.OPEN_SNACKBAR({ message: `Could not add ${tail.name} -> ${head.name} relation`, kind: SnackbarKind.ERROR, })); - } - }; interface DeleteGroupMemberArgs { - user: { uuid: string, name: string }; - group: { uuid: string, name: string }; + link: { uuid: string }; dispatch: Dispatch; permissionService: PermissionService; } -export const deleteGroupMember = async ({ user, group, ...args }: DeleteGroupMemberArgs) => { - +export const deleteGroupMember = async ({ link, ...args }: DeleteGroupMemberArgs) => { await deletePermission({ - tail: group, - head: user, + uuid: link.uuid, ...args, }); - }; interface DeletePermissionLinkArgs { - head: { uuid: string, name: string }; - tail: { uuid: string, name: string }; + uuid: string; dispatch: Dispatch; permissionService: PermissionService; } -export const deletePermission = async ({ head, tail, dispatch, permissionService }: DeletePermissionLinkArgs) => { - +export const deletePermission = async ({ uuid, dispatch, permissionService }: DeletePermissionLinkArgs) => { try { - const permissionsResponse = await permissionService.list({ - filters: new FilterBuilder() - .addEqual('tailUuid', tail.uuid) - .addEqual('headUuid', head.uuid) + .addEqual('uuid', uuid) .getFilters() - }); - const [permission] = permissionsResponse.items; - if (permission) { - await permissionService.delete(permission.uuid); - } else { - throw new Error('Permission not found'); - } - - } catch (e) { - dispatch(snackbarActions.OPEN_SNACKBAR({ - message: `Could not delete ${tail.name} -> ${head.name} relation`, + message: `Could not delete ${uuid} permission`, kind: SnackbarKind.ERROR, })); - } - -}; \ No newline at end of file +};