Merge branch '15856-illegal-chars-warning'

[arvados-workbench2.git] / src / components / breadcrumbs / breadcrumbs.tsx

diff --git a/src/components/breadcrumbs/breadcrumbs.tsx b/src/components/breadcrumbs/breadcrumbs.tsx
index 6c2d1fb22afeaf4127d19338ebb307b48abb4f54..207823307c9284b31fa0a4ca969f974b74a9ea23 100644 (file)
--- a/src/components/breadcrumbs/breadcrumbs.tsx
+++ b/src/components/breadcrumbs/breadcrumbs.tsx
@@ -3,77 +3,63 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import * as React from 'react';
-import { Button, Grid, StyleRulesCallback, WithStyles } from '@material-ui/core';
+import { Button, Grid, StyleRulesCallback, WithStyles, Typography, Tooltip } from '@material-ui/core';
 import ChevronRightIcon from '@material-ui/icons/ChevronRight';
 import { withStyles } from '@material-ui/core';
+import { IllegalNamingWarning } from '../warning/warning';
 
 export interface Breadcrumb {
-    label: string
+    label: string;
 }
 
-interface BreadcrumbsDataProps {
-    items: Breadcrumb[]
-}
-
-interface BreadcrumbsActionProps {
-    onClick: (breadcrumb: Breadcrumb) => any
-}
+type CssRules = "item" | "currentItem" | "label";
 
-type BreadcrumbsProps = BreadcrumbsDataProps & BreadcrumbsActionProps & WithStyles<CssRules>;
+const styles: StyleRulesCallback<CssRules> = theme => ({
+    item: {
+        opacity: 0.6
+    },
+    currentItem: {
+        opacity: 1
+    },
+    label: {
+        textTransform: "none"
+    }
+});
 
-class Breadcrumbs extends React.Component<BreadcrumbsProps> {
+export interface BreadcrumbsProps {
+    items: Breadcrumb[];
+    onClick: (breadcrumb: Breadcrumb) => void;
+    onContextMenu: (event: React.MouseEvent<HTMLElement>, breadcrumb: Breadcrumb) => void;
+}
 
-    render() {
-        const { classes, onClick } = this.props;
-        return <Grid container alignItems="center">
-            {
-                this.getInactiveItems().map((item, index) => (
-                    <React.Fragment key={index}>
+export const Breadcrumbs = withStyles(styles)(
+    ({ classes, onClick, onContextMenu, items }: BreadcrumbsProps & WithStyles<CssRules>) =>
+    <Grid container alignItems="center" wrap="nowrap">
+    {
+        items.map((item, index) => {
+            const isLastItem = index === items.length - 1;
+            const isFirstItem = index === 0;
+            return (
+                <React.Fragment key={index}>
+                    {isFirstItem ? null : <IllegalNamingWarning name={item.label} />}
+                    <Tooltip title={item.label}>
                         <Button
                             color="inherit"
-                            className={classes.inactiveItem}
+                            className={isLastItem ? classes.currentItem : classes.item}
                             onClick={() => onClick(item)}
-                        >
-                            {item.label}
+                            onContextMenu={event => onContextMenu(event, item)}>
+                            <Typography
+                                noWrap
+                                color="inherit"
+                                className={classes.label}>
+                                {item.label}
+                            </Typography>
                         </Button>
-                        <ChevronRightIcon color="inherit" className={classes.inactiveItem} />
-                    </React.Fragment>
-                ))
-            }
-            {
-                this.getActiveItem().map((item, index) => (
-                    <Button
-                        color="inherit"
-                        key={index}
-                        onClick={() => onClick(item)}
-                    >
-                        {item.label}
-                    </Button>
-                ))
-            }
-        </Grid>
-    }
-
-    getInactiveItems = () => {
-        return this.props.items.slice(0, -1)
-    }
-
-    getActiveItem = () => {
-        return this.props.items.slice(-1)
+                    </Tooltip>
+                    {!isLastItem && <ChevronRightIcon color="inherit" className={classes.item} />}
+                </React.Fragment>
+            );
+        })
     }
-
-}
-
-type CssRules = 'inactiveItem'
-
-const styles: StyleRulesCallback<CssRules> = theme => {
-    const { unit } = theme.spacing
-    return {
-        inactiveItem: {
-            opacity: 0.6
-        }
-    }
-}
-
-export default withStyles(styles)(Breadcrumbs)
-
+    </Grid>
+);