Fix CR comments

[arvados-workbench2.git] / src / models / tree.ts

diff --git a/src/models/tree.ts b/src/models/tree.ts
index 1f1e308a68d4923a501e18e15f6f39675db2116a..8b66e50da7961df58c5c60f0b8fd23556f749467 100644 (file)
--- a/src/models/tree.ts
+++ b/src/models/tree.ts
@@ -1,5 +1,3 @@
-import { Children } from "../../node_modules/@types/react";
-
 // Copyright (C) The Arvados Authors. All rights reserved.
 //
 // SPDX-License-Identifier: AGPL-3.0
@@ -23,27 +21,41 @@ export const setNode = <T>(node: TreeNode<T>) => (tree: Tree<T>): Tree<T> => {
     const [newTree] = [tree]
         .map(tree => getNode(node.id)(tree) === node
             ? tree
-            : Object.assign({}, tree, { [node.id]: node }))
+            : {...tree, [node.id]: node})
         .map(addChild(node.parent, node.id));
     return newTree;
 };
 
-export const addChild = (parentId: string, childId: string) => <T>(tree: Tree<T>): Tree<T> => {
-    const node = getNode(parentId)(tree);
-    if (node) {
-        const children = node.children.some(id => id === childId)
-            ? node.children
-            : [...node.children, childId];
+export const getNodeValue = (id: string) => <T>(tree: Tree<T>) => {
+    const node = getNode(id)(tree);
+    return node ? node.value : undefined;
+};
 
-        const newNode = children === node.children
-            ? node
-            : { ...node, children };
+export const setNodeValue = (id: string) => <T>(value: T) => (tree: Tree<T>) => {
+    const node = getNode(id)(tree);
+    return node
+        ? setNode(mapNodeValue(() => value)(node))(tree)
+        : tree;
+};
 
-        return setNode(newNode)(tree);
-    }
-    return tree;
+export const setNodeValueWith = <T>(mapFn: (value: T) => T) => (id: string) => (tree: Tree<T>) => {
+    const node = getNode(id)(tree);
+    return node
+        ? setNode(mapNodeValue(mapFn)(node))(tree)
+        : tree;
 };
 
+export const mapTreeValues = <T, R>(mapFn: (value: T) => R) => (tree: Tree<T>): Tree<R> =>
+    getNodeDescendants('')(tree)
+        .map(id => getNode(id)(tree))
+        .map(mapNodeValue(mapFn))
+        .reduce((newTree, node) => setNode(node)(newTree), createTree<R>());
+
+export const mapTree = <T, R>(mapFn: (node: TreeNode<T>) => TreeNode<R>) => (tree: Tree<T>): Tree<R> =>
+    getNodeDescendants('')(tree)
+        .map(id => getNode(id)(tree))
+        .map(mapFn)
+        .reduce((newTree, node) => setNode(node)(newTree), createTree<R>());
 
 export const getNodeAncestors = (id: string) => <T>(tree: Tree<T>): string[] => {
     const node = getNode(id)(tree);
@@ -70,20 +82,7 @@ export const getNodeDescendants = (id: string, limit = Infinity) => <T>(tree: Tr
 export const getNodeChildren = (id: string) => <T>(tree: Tree<T>): string[] =>
     getNodeDescendants(id, 0)(tree);
 
-export const mapNodes = (ids: string[]) => <T>(mapFn: (node: TreeNode<T>) => TreeNode<T>) => (tree: Tree<T>): Tree<T> =>
-    ids
-        .map(id => getNode(id)(tree))
-        .map(mapFn)
-        .map(setNode)
-        .reduce((tree, update) => update(tree), tree);
-
-export const mapTree = <T, R>(mapFn: (node: TreeNode<T>) => TreeNode<R>) => (tree: Tree<T>): Tree<R> =>
-    getNodeDescendants('')(tree)
-        .map(id => getNode(id)(tree))
-        .map(mapFn)
-        .reduce((newTree, node) => setNode(node)(newTree), createTree<R>());
-
-export const mapNodeValue = <T>(mapFn: (value: T) => T) => (node: TreeNode<T>) =>
+const mapNodeValue = <T, R>(mapFn: (value: T) => R) => (node: TreeNode<T>): TreeNode<R> =>
     ({ ...node, value: mapFn(node.value) });
 
 const getRootNodeChildren = <T>(tree: Tree<T>) =>
@@ -91,5 +90,18 @@ const getRootNodeChildren = <T>(tree: Tree<T>) =>
         .keys(tree)
         .filter(id => getNode(id)(tree)!.parent === TREE_ROOT_ID);
 
+const addChild = (parentId: string, childId: string) => <T>(tree: Tree<T>): Tree<T> => {
+    const node = getNode(parentId)(tree);
+    if (node) {
+        const children = node.children.some(id => id === childId)
+            ? node.children
+            : [...node.children, childId];
 
+        const newNode = children === node.children
+            ? node
+            : { ...node, children };
 
+        return setNode(newNode)(tree);
+    }
+    return tree;
+};