19504: Fix breadcrumbs height to improve text vertical centering

[arvados-workbench2.git] / src / components / breadcrumbs / breadcrumbs.tsx

diff --git a/src/components/breadcrumbs/breadcrumbs.tsx b/src/components/breadcrumbs/breadcrumbs.tsx
index 4868e137f9f6b11065bdd2dbfaf3d3ff4ac642da..626573962425125fc14f7adf859d80f506c0b189 100644 (file)
--- a/src/components/breadcrumbs/breadcrumbs.tsx
+++ b/src/components/breadcrumbs/breadcrumbs.tsx
@@ -2,68 +2,106 @@
 //
 // SPDX-License-Identifier: AGPL-3.0
 
-import * as React from 'react';
+import React from 'react';
 import { Button, Grid, StyleRulesCallback, WithStyles, Typography, Tooltip } from '@material-ui/core';
 import ChevronRightIcon from '@material-ui/icons/ChevronRight';
 import { withStyles } from '@material-ui/core';
+import { IllegalNamingWarning } from '../warning/warning';
+import { IconType, FreezeIcon } from 'components/icon/icon';
+import grey from '@material-ui/core/colors/grey';
+import { ResourcesState } from 'store/resources/resources';
+import classNames from 'classnames';
+import { ArvadosTheme } from 'common/custom-theme';
 
 export interface Breadcrumb {
     label: string;
+    icon?: IconType;
+    uuid: string;
 }
 
-interface BreadcrumbsProps {
+type CssRules = "item" | "label" | "icon" | "frozenIcon";
+
+const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
+    item: {
+        borderRadius: '16px',
+        height: '32px',
+        backgroundColor: theme.customs.colors.grey300,
+        '&.parentItem': {
+            backgroundColor: `${theme.customs.colors.grey300}99`,
+        },
+        '&:hover': {
+            backgroundColor: theme.customs.colors.grey400,
+        },
+        '&.parentItem:hover': {
+            backgroundColor: `${theme.customs.colors.grey400}99`,
+        },
+    },
+    label: {
+        textTransform: "none",
+        paddingRight: '3px',
+        paddingLeft: '3px',
+        lineHeight: '1.4',
+    },
+    icon: {
+        fontSize: 20,
+        color: grey["600"],
+        marginRight: '5px',
+    },
+    frozenIcon: {
+        fontSize: 20,
+        color: grey["600"],
+        marginLeft: '3px',
+    },
+});
+
+export interface BreadcrumbsProps {
     items: Breadcrumb[];
+    resources: ResourcesState;
     onClick: (breadcrumb: Breadcrumb) => void;
     onContextMenu: (event: React.MouseEvent<HTMLElement>, breadcrumb: Breadcrumb) => void;
 }
 
-const Breadcrumbs: React.SFC<BreadcrumbsProps & WithStyles<CssRules>> = ({ classes, onClick, onContextMenu, items }) => {
-    return <Grid container alignItems="center" wrap="nowrap">
-        {
-            items.map((item, index) => {
-                const isLastItem = index === items.length - 1;
-                return (
-                    <React.Fragment key={index}>
-                        <Tooltip title={item.label}>
-                            <Button
+export const Breadcrumbs = withStyles(styles)(
+    ({ classes, onClick, onContextMenu, items, resources }: BreadcrumbsProps & WithStyles<CssRules>) =>
+    <Grid container data-cy='breadcrumbs' alignItems="center" wrap="nowrap">
+    {
+        items.map((item, index) => {
+            const isLastItem = index === items.length - 1;
+            const isFirstItem = index === 0;
+            const Icon = item.icon || (() => (null));
+            return (
+                <React.Fragment key={index}>
+                    {isFirstItem ? null : <IllegalNamingWarning name={item.label} />}
+                    <Tooltip title={item.label}>
+                        <Button
+                            data-cy={
+                                isFirstItem
+                                ? 'breadcrumb-first'
+                                : isLastItem
+                                    ? 'breadcrumb-last'
+                                    : false}
+                            className={classNames(
+                                isLastItem ? null : 'parentItem',
+                                classes.item
+                            )}
+                            onClick={() => onClick(item)}
+                            onContextMenu={event => onContextMenu(event, item)}>
+                            <Icon className={classes.icon} />
+                            <Typography
+                                noWrap
                                 color="inherit"
-                                className={isLastItem ? classes.currentItem : classes.item}
-                                onClick={() => onClick(item)}
-                                onContextMenu={event => onContextMenu(event, item)}>
-                                <Typography
-                                    noWrap
-                                    color="inherit"
-                                    className={classes.label}>
-                                    {item.label}
-                                </Typography>
-                            </Button>
-                        </Tooltip>
-                        {
-                            !isLastItem && <ChevronRightIcon color="inherit" className={classes.item} />
-                        }
-                    </React.Fragment>
-                );
-            })
-        }
-    </Grid>;
-};
-
-type CssRules = "item" | "currentItem" | "label";
-
-const styles: StyleRulesCallback<CssRules> = theme => {
-    const { unit } = theme.spacing;
-    return {
-        item: {
-            opacity: 0.6
-        },
-        currentItem: {
-            opacity: 1
-        },
-        label: {
-            textTransform: "none"
-        }
-    };
-};
-
-export default withStyles(styles)(Breadcrumbs);
-
+                                className={classes.label}>
+                                {item.label}
+                            </Typography>
+                            {
+                                (resources[item.uuid] as any)?.frozenByUuid ? <FreezeIcon className={classes.frozenIcon} /> : null
+                            }
+                        </Button>
+                    </Tooltip>
+                    {!isLastItem && <ChevronRightIcon color="inherit" className={'parentItem'} />}
+                </React.Fragment>
+            );
+        })
+    }
+    </Grid>
+);