16067: Ignores certain fields on create & update api calls.

[arvados-workbench2.git] / src / services / common-service / common-service.ts

diff --git a/src/services/common-service/common-service.ts b/src/services/common-service/common-service.ts
index 262b5c5d55767beb6b851a102906e36c31c38d9d..44233eb17bd2f683ecf4fcb48459160dd583119e 100644 (file)
--- a/src/services/common-service/common-service.ts
+++ b/src/services/common-service/common-service.ts
@@ -6,6 +6,7 @@ import * as _ from "lodash";
 import { AxiosInstance, AxiosPromise } from "axios";
 import * as uuid from "uuid/v4";
 import { ApiActions } from "~/services/api/api-actions";
+import * as QueryString from "query-string";
 
 interface Errors {
     errors: string[];
@@ -35,11 +36,13 @@ export class CommonService<T> {
     protected serverApi: AxiosInstance;
     protected resourceType: string;
     protected actions: ApiActions;
+    protected readOnlyFields: string[];
 
-    constructor(serverApi: AxiosInstance, resourceType: string, actions: ApiActions) {
+    constructor(serverApi: AxiosInstance, resourceType: string, actions: ApiActions, readOnlyFields: string[] = []) {
         this.serverApi = serverApi;
         this.resourceType = '/' + resourceType;
         this.actions = actions;
+        this.readOnlyFields = readOnlyFields;
     }
 
     static mapResponseKeys = (response: { data: any }) =>
@@ -114,20 +117,29 @@ export class CommonService<T> {
             order: order ? order : undefined
         };
 
-        // Using the POST special case to avoid URI length 414 errors.
-        // See https://doc.arvados.org/v1.4/api/requests.html
-        const formData = new FormData();
-        formData.append("_method", "GET");
-        Object.keys(params).map(key => {
-            if (params[key] !== undefined) {
-                formData.append(key, params[key]);
-            }
-        });
-
-        return CommonService.defaultResponse(
-            this.serverApi.post(this.resourceType, formData),
-            this.actions
-        );
+        if (QueryString.stringify(params).length <= 1500) {
+            return CommonService.defaultResponse(
+                this.serverApi.get(this.resourceType, { params }),
+                this.actions
+            );
+        } else {
+            // Using the POST special case to avoid URI length 414 errors.
+            const formData = new FormData();
+            formData.append("_method", "GET");
+            Object.keys(params).map(key => {
+                if (params[key] !== undefined) {
+                    formData.append(key, params[key]);
+                }
+            });
+            return CommonService.defaultResponse(
+                this.serverApi.post(this.resourceType, formData, {
+                    params: {
+                        _method: 'GET'
+                    }
+                }),
+                this.actions
+            );
+        }
     }
 
     update(uuid: string, data: Partial<T>) {