From d9ede8264d9a9cbbd6eab15f98abc2326488bc7b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Javier=20B=C3=A9rtoli?= <javier@netmanagers.com.ar>
Date: Fri, 16 Oct 2020 14:04:24 -0300
Subject: [PATCH 1/1] fix(config): prevent duplicated, undesired entries

---
 arvados/defaults.yaml                                | 8 --------
 arvados/files/default/config.tmpl.jinja              | 8 ++------
 test/integration/workbench/controls/services_spec.rb | 2 +-
 3 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/arvados/defaults.yaml b/arvados/defaults.yaml
index a053b7f..38aa764 100644
--- a/arvados/defaults.yaml
+++ b/arvados/defaults.yaml
@@ -52,14 +52,6 @@ arvados:
       key: ''
       insecure: false
 
-    Login:
-      # Google:
-      #   ClientID: 94....apps.googleusercontent.com
-      #   ClientSecret: FL....r
-
-      PAM:
-        Enable: true
-
   ### THESE ARE THE PACKAGES AND DAEMONS BASIC CONFIGS
   ##### API
   api:
diff --git a/arvados/files/default/config.tmpl.jinja b/arvados/files/default/config.tmpl.jinja
index fe33a2a..46923cd 100644
--- a/arvados/files/default/config.tmpl.jinja
+++ b/arvados/files/default/config.tmpl.jinja
@@ -33,12 +33,6 @@ Clusters:
       {{ arvados.cluster.Collections | yaml(False) | indent(6) }}
     {%- endif %}
 
-    Login:
-      {{ arvados.cluster.Login | yaml(False) | indent(6) }}
-
-    Users:
-      {{ arvados.cluster.Users | yaml(False) | indent(6) }}
-
     TLS:
       Certificate: {{ arvados.cluster.tls.certificate | yaml_encode }}
       Key: {{ arvados.cluster.tls.key | yaml_encode }}
@@ -56,9 +50,11 @@ Clusters:
         'Containers',
         'Git',
         'InstanceTypes',
+        'Login',
         'Mail',
         'RemoteClusters',
         'SystemLogs',
+        'Users',
         'Volumes'
       ]
     %}
diff --git a/test/integration/workbench/controls/services_spec.rb b/test/integration/workbench/controls/services_spec.rb
index f4e6dd2..15ae30f 100644
--- a/test/integration/workbench/controls/services_spec.rb
+++ b/test/integration/workbench/controls/services_spec.rb
@@ -4,7 +4,7 @@ control 'arvados workbench service' do
   impact 0.5
   title 'should be running and enabled'
 
-  describe service('ssh') do
+  describe service('nginx') do
     it { should be_enabled }
     it { should be_running }
   end
-- 
2.30.2