fix(conditionals): wrong onlyif specification

[arvados-formula.git] / arvados / shell / package / install.sls

diff --git a/arvados/shell/package/install.sls b/arvados/shell/package/install.sls
index d2de401208372123f009cab4b647f50cd7d372cd..6d1300fe21de5da1065b4c2ca2173e523bb8643b 100644 (file)
--- a/arvados/shell/package/install.sls
+++ b/arvados/shell/package/install.sls
@@ -6,6 +6,10 @@
 {%- set sls_ruby_install = tplroot ~ '.ruby.package.install' %}
 {%- from tplroot ~ "/map.jinja" import arvados with context %}
 
+{%- if arvados.ruby.manage_ruby %}
+  {%- set ruby_dep = 'rvm' if arvados.ruby.use_rvm else 'pkg' %}
+{%- endif %}
+
 include:
   - {{ sls_ruby_install }}
 
@@ -17,7 +21,6 @@ arvados-shell-package-install-pkg-installed:
         {%- if package in [
           'arvados-client',
           'arvados-src',
-          'libpam-arvados-go',
           'python3-arvados-fuse',
           'python3-arvados-python-client',
           'python3-arvados-cwl-runner',
@@ -31,22 +34,15 @@ arvados-shell-package-install-pkg-installed:
 arvados-shell-package-install-gems-deps-pkg-installed:
   pkg.installed:
     - pkgs: {{ arvados.ruby.gems_deps | json }}
-    - only_if: test "{{ arvados.ruby.manage_gems_deps | lower }}" = "true"
+    - onlyif: test "{{ arvados.ruby.manage_gems_deps | lower }}" = "true"
 
-{% for gm in arvados.shell.gem.name %}
+{%- for gm in arvados.shell.gem.name %}
 arvados-shell-package-install-gem-{{ gm }}-installed:
   gem.installed:
     - name: {{ gm }}
     - require:
-      - pkg: arvados-shell-package-install-gems-deps-pkg-installed
       {%- if arvados.ruby.manage_ruby %}
-        {%- if salt['grains.get']('osfinger') != 'CentOS Linux-7' %}
-      - pkg: arvados-ruby-package-install-ruby-pkg-installed
-        {%- else %}
-      # - rvm: arvados-ruby-package-install-ruby-gemset-present
-      - rvm: arvados-ruby-package-install-ruby-rvm-installed
-      # - rvm: gemset_present
-    # - ruby: ruby-2.5.7@arvados
-        {%- endif %}
+      - {{ ruby_dep }}: arvados-ruby-package-install-ruby-{{ ruby_dep }}-installed
       {%- endif %}
-{% endfor %}
+      - pkg: arvados-shell-package-install-gems-deps-pkg-installed
+{%- endfor %}